Skip to content

Use fabric to save default provider for the project #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2024
Merged

Use fabric to save default provider for the project #853

merged 3 commits into from
Nov 13, 2024

Conversation

edwardrf
Copy link
Contributor

@edwardrf edwardrf commented Nov 13, 2024 •
edited by commit111
Loading

Description

Added GetSelectedProvider and SetSelectedProvider Fabric grpc calls to save a provider preference. User can re-select the provider by using --provider=auto to trigger the prompt.

Also clean up how:

  1. AWS missing credential is handled
  2. Implement DO whoami

Linked Issues

#747
#782

Checklist

@edwardrf edwardrf requested a review from lionello November 13, 2024 00:29
@edwardrf edwardrf marked this pull request as ready for review November 13, 2024 03:21
@edwardrf edwardrf changed the title Use provider from compose file or saved local state file Use fabric to save default provider for the project Nov 13, 2024
lionello
lionello reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User project-name from loader and enum for Provider in proto

@edwardrf edwardrf requested a review from lionello November 13, 2024 19:17
@lionello lionello merged commit c9be979 into main Nov 13, 2024
13 checks passed
@lionello lionello deleted the edw/persist-provider-selection branch November 13, 2024 19:42
@commit111 commit111 mentioned this pull request Nov 14, 2024
Merged
3 tasks
@lionello lionello mentioned this pull request Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanstephens jordanstephens Awaiting requested review from jordanstephens

@lionello lionello Awaiting requested review from lionello lionello is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardrf @lionello @edw-defang